Ensure unresolved conversations block merges
Why this matters
Requiring all review comments to be resolved before merging ensures that no reviewer feedback, bug report, or security concern is ignored.
Unresolved conversations often indicate unfinished discussions or unaddressed findings in a pull request.
By enforcing this setting, you ensure that:
- Review feedback is acknowledged and resolved before code is merged
- Code quality and security concerns are fully addressed
- Peer review remains a meaningful control within your secure development lifecycle
Without this safeguard, unresolved feedback could be bypassed, leading to errors, vulnerabilities, or missed compliance issues.
What this check does
This check verifies that the branch protection rule for the repository has “Require conversation resolution before merging” enabled.
When active, GitHub blocks the merge of a pull request if any review comments remain unresolved.
How to fix it
From the GitHub Web Console
- Go to your repository on GitHub.
- Navigate to Settings → Branches.
- Under Branch protection rules, click Add rule or edit an existing one.
- In the rule configuration, scroll to Require conversation resolution before merging.
- Check this option to ensure all review threads must be resolved prior to merge.
- Click Save changes.
Once enabled, GitHub will automatically block merges until every conversation in the pull request has been marked as resolved.
Exceptions
- This rule applies only to pull requests that have open review comments; it does not affect draft or unreviewed pull requests.
- Admins can bypass this restriction unless “Include administrators” is also selected in the branch protection rule.
- If a comment thread is reopened after being resolved, the pull request will again be blocked until it is closed.